fix: resolve #4284 — Claude Code Review Report#4290
Open
chinhkrb113 wants to merge 4 commits into
Open
Conversation
Fixes transact-rs#4284 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Fixes transact-rs#4284 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Fixes transact-rs#4284 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Fixes transact-rs#4284 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined multi-file contribution:
Changes
sqlx-core/src/any/arguments.rssqlx-core/src/any/connection/mod.rssqlx-sqlite/src/logger.rssqlx-macros-core/src/query/metadata.rsWhy
sqlx-core/src/any/arguments.rs: InAnyArguments::convert_into, the NULL float type mappings are swapped.AnyTypeInfoKind::Realcorresponds tof32but is encoded asOption::<f64>::None, andAnyTypeInfoKind::Doublecorresponds tof64but is encoded asOption::<f32>::None. Binding a NULLf32/f64through theAnydriver sends the wrong SQL type hint, which can produce a type-mismatch error on strongly-typed backends like Postgres.