Android 0.2.0: new assembly wrapper & WorkManager remote signatures #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with a new AndroidAssembly plus AndroidAssemblyListener built on the contemporary Java SDK workflow. The new wrapper runs uploads asynchronously via saveAsync(), wires SSE progress into listener callbacks, and still supports pause/resume.
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
transloadit-android/src/main/java/com/transloadit/android/sdk/AndroidAssemblyUploadWorker.java
Outdated
Show resolved
Hide resolved
transloadit-android/src/main/java/com/transloadit/android/sdk/AndroidAssemblyUploadWorker.java
Outdated
Show resolved
Hide resolved
kvz
changed the title
kvz
changed the title
This reverts commit 113ca40.
kvz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AndroidAsyncAssemblywith a newAndroidAssemblythat defaults callbacks to the main thread, shares a daemon executor, and exposes listener helperstransloadit_android_sdk_urls, require JDK 17+ to build while continuing to ship Java 11 bytecode for consumersAndroidAssemblyWorkConfigandAndroidAssemblyUploadWorkerso WorkManager jobs can run with inline secrets or remote signature providers (including remote-only/http/importflows)com.transloadit.sdk:transloadit:2.2.4Fixes #19
Fixes #14
Fixes #2
Testing