feat: replace brand mark with new mountain/river logo#37
Merged
Conversation
… variants Replaces the old purple/orange favicon.ico artwork and the SVG-wrapped raster icons (which were never actually vector — just base64 PNGs inside an .svg wrapper) with the new logo, supplied as two proper theme-paired PNGs: a dark-ground variant and a light-ground variant, each with transparent sky and an opaque ground fill matched to its theme. Two different treatments, matched to how each asset is actually used: - App-icon-style assets (favicon.ico, favicon-32/96, apple-touch-icon, android-chrome-192/512, OG image) are composited fully opaque onto solid Murky Depths navy. These get embedded in contexts this site can't control (browser tabs, social cards, phone home screens, possibly light or dark) — one deliberate square mark beats relying on transparency blending unpredictably. - In-page assets (nav logo, footer logo, hero background) keep native transparency and swap dark/light variant with the site's own theme toggle, same [data-theme] pattern already used elsewhere. The nav's existing home-hero override (forcing light text on the fixed-dark hero regardless of site theme) is extended to also force the dark-ground logo variant there, for the same reason. Also fixes site.webmanifest's theme_color/background_color, which were still the pre-rebrand #08051a instead of the current #02273A, and a structured-data logo URL that pointed at a now-deleted SVG. One bug caught during verification: Astro's CSS scoping auto-appends its scope hash to every selector segment, including ancestor selectors owned by another component. [data-theme="light"] .foo compiles to a selector requiring both attributes on the same element, which never matches since data-theme lives on <html> and the scope hash lives on Nav's own elements — silently never matching, not an error. Wrapped it in :global(), matching the existing :global(body.home) precedent already in this same file for the identical reason. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old purple/orange favicon.ico artwork and the SVG-wrapped raster icons (which were never actually vector — just base64 PNGs inside an
.svgwrapper) with the new logo, supplied as two theme-paired PNGs: a dark-ground variant and a light-ground variant, each with transparent sky and an opaque ground fill matched to its theme.Two treatments, matched to how each asset is actually used:
[data-theme]pattern already used elsewhere. The nav's existing home-hero override (forcing light text on the fixed-dark hero regardless of site theme) is extended to also force the dark-ground logo variant there, for the same reason.Also fixes
site.webmanifest'stheme_color/background_color, which were still the pre-rebrand#08051ainstead of the current#02273A, and a structured-datalogoURL that pointed at a now-deleted SVG.Bug caught during verification: Astro's CSS scoping auto-appends its scope hash to every selector segment, including ancestor selectors owned by another component.
[data-theme="light"] .foocompiles to a selector requiring both attributes on the same element, which never matches —data-themelives on<html>, the scope hash lives on Nav's own elements. It fails silently, not as an error. Wrapped it in:global(), matching the existing:global(body.home)precedent already in this same file for the identical reason.Test plan
npm run buildclean🤖 Generated with Claude Code