Skip to content

add purple color to theme #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pragyajha wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add purple color to theme #199

pragyajha wants to merge 2 commits into from

Conversation

@pragyajha
Copy link
Contributor

@pragyajha pragyajha commented Apr 7, 2020

No description provided.

@kamleshchandnani
Copy link
Contributor

kamleshchandnani commented Apr 7, 2020 •
edited
Loading

Deploy preview for leaf-ui ready!

Built with commit 3783c85

https://deploy-preview-199--leaf-ui.netlify.com

@pragyajha pragyajha requested review from a team and kamleshchandnani and removed request for a team April 7, 2020 12:29
kamleshchandnani
kamleshchandnani suggested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@kamleshchandnani kamleshchandnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no. There’s already a file theme.web.js. That’s how everything works based on extension

@kamleshchandnani
Copy link
Contributor

kamleshchandnani commented Apr 7, 2020

Put all your changes in theme.web.js

@sumit-gupta91
Copy link

sumit-gupta91 commented Apr 8, 2020 •
edited
Loading

Were we not using cybertron-components, in all the projects in Treebo or are some projects in monorepo still using leaf-ui ??

@pragyajha
Copy link
Contributor Author

pragyajha commented Apr 8, 2020

Oh no. There’s already a file theme.web.js. That’s how everything works based on extension

My bad! this is some old web folder which was already created. Will change it.

@pragyajha
Copy link
Contributor Author

pragyajha commented Apr 8, 2020 •
edited
Loading

Were we not using cybertron-components, in all the projects in Treebo or are some projects in monorepo still using leaf-ui ??
Few old code from hotrod and rodimus are still using leaf-ui. Have asked team to move to cybertron components completely. Adding purlpe color to existing theme, so it's easier for designers to know what theme colors we have:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamleshchandnani kamleshchandnani kamleshchandnani approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pragyajha @kamleshchandnani @sumit-gupta91