[WIP] Drastic changes. GTK4 #366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ripped out entire Cairo code paths - Removed features from voice overlay - - Circle avatars removed - - Right align split into two options - - Removed text baseline adjustment - - Floating window positions - - Removed user overflow options - Reorganised config reading into each overlay - Broken and not yet fixed: - - voice: Only speaking & speaking grace - - voice: Hide on mouseover - - text: All of it - - notification: All of it - - settings: monitor selection - - settings: systemtray & menu - - x11: all support
- Reach out to XLib to set window position & above-hint for X11 desktops - Use PIL after all, to allow Webp and potentially other image formats - Brought Notifications back to working state - Implemented text align for notifications - Fixed voice overlay blanking when leaving a channel
- Stopped connector caching text chat, just pass on messages as they happen - reimplemented text overlay - text chat hides when empty
- Added stub for update message
- implemented recolour of loaded pixbuf - made svg files for mute and deaf - Fixed section and config reset crash - reimplemented circle avatars after all - Improved talking border clarity at larger size - We could probably let user choose mute & deaf pix. But not happening right now -
- make data handlers into a gtk box, not window itself - non-compositor code path should quit for now until we make any kind of working XShape impl - Fix channel rpc by keeping the reference...
- - Added 'No discord present' - - Added 'Discord version invalid' - - Flattened all intermediary states to 'Voice chat joining' - - Flattened both connected to one state - Version invalid ALWAYS shows on voice overlay - 'No discord' is on by default - Retry connection starts at 5 seconds and scales up another 5 seconds every consecutive fail - Strip voice cache and text cache from connector - Unset cached 'authed' on reconnect - Detect invalid discord versions - Moved much more logic for voice overlay into UserBox - Request new user avatar image only when details actually changed - Fixed only_talking and grace - Fixed X11 with compositor - Fixed Gamescope compat - XWayland needs testing
- Fixed edgecase crashes in notifications - Set notification and text to hide at start, before content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Road to v1.0.0
This PR represents a complete overhaul of this project. The project had languished in GTK3 for quite long enough and needed to be updated. The old Cairo-drawing code path was a tangle.
This update WILL break users experience, but the plan is to break the least number of features and the least number of places it can run.
Requirements before merging
MUST HAVE
Preferable
Would-Be-Nice
Changes so far
Right alignsplit into two optionsTo fix or remove