Skip to content

Parallelize sorting of PrecomputedNeighborhoodSearch and preserve across copy_neighborhood_search#157

Open
efaulhaber wants to merge 2 commits into
mainfrom
ef/fix-precomputed
Open

Parallelize sorting of PrecomputedNeighborhoodSearch and preserve across copy_neighborhood_search#157
efaulhaber wants to merge 2 commits into
mainfrom
ef/fix-precomputed

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

No description provided.

@efaulhaber efaulhaber requested a review from Copilot May 22, 2026 11:16
@efaulhaber efaulhaber self-assigned this May 22, 2026
@efaulhaber efaulhaber added the bug Something isn't working label May 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves PrecomputedNeighborhoodSearch neighbor-list handling by (1) parallelizing sorting of the stored neighbor lists and (2) ensuring the sort_neighbor_lists configuration is preserved when copying a neighborhood search.

Changes:

  • Parallelize sorteach!(::DynamicVectorOfVectors) by sorting columns concurrently using the project’s @threaded abstraction.
  • Preserve sort_neighbor_lists when cloning a PrecomputedNeighborhoodSearch via copy_neighborhood_search.
  • Add additional @inbounds annotations in hot-path list population.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/vector_of_vectors.jl Adds threaded per-column sorting for DynamicVectorOfVectors and applies additional @inbounds in pushat!.
src/nhs_precomputed.jl Uses @inbounds when filling neighbor lists and propagates sort_neighbor_lists through copy_neighborhood_search.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/nhs_precomputed.jl Outdated
Comment thread src/vector_of_vectors.jl
Comment thread src/nhs_precomputed.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.94%. Comparing base (f25b0ab) to head (e19d132).

Files with missing lines Patch % Lines
src/vector_of_vectors.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   86.06%   84.94%   -1.12%     
==========================================
  Files          15       15              
  Lines         739      744       +5     
==========================================
- Hits          636      632       -4     
- Misses        103      112       +9     
Flag Coverage Δ
unit 84.94% <71.42%> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber efaulhaber requested a review from svchb May 22, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants