Parallelize sorting of PrecomputedNeighborhoodSearch and preserve across copy_neighborhood_search#157
Parallelize sorting of PrecomputedNeighborhoodSearch and preserve across copy_neighborhood_search#157efaulhaber wants to merge 2 commits into
PrecomputedNeighborhoodSearch and preserve across copy_neighborhood_search#157Conversation
…cross `copy_neighborhood_search`
There was a problem hiding this comment.
Pull request overview
This PR improves PrecomputedNeighborhoodSearch neighbor-list handling by (1) parallelizing sorting of the stored neighbor lists and (2) ensuring the sort_neighbor_lists configuration is preserved when copying a neighborhood search.
Changes:
- Parallelize
sorteach!(::DynamicVectorOfVectors)by sorting columns concurrently using the project’s@threadedabstraction. - Preserve
sort_neighbor_listswhen cloning aPrecomputedNeighborhoodSearchviacopy_neighborhood_search. - Add additional
@inboundsannotations in hot-path list population.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vector_of_vectors.jl |
Adds threaded per-column sorting for DynamicVectorOfVectors and applies additional @inbounds in pushat!. |
src/nhs_precomputed.jl |
Uses @inbounds when filling neighbor lists and propagates sort_neighbor_lists through copy_neighborhood_search. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 86.06% 84.94% -1.12%
==========================================
Files 15 15
Lines 739 744 +5
==========================================
- Hits 636 632 -4
- Misses 103 112 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.