Fix steady state callback interval handling#1180
Merged
efaulhaber merged 11 commits intoMay 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 90.00% 90.04% +0.03%
==========================================
Files 135 136 +1
Lines 10569 10594 +25
==========================================
+ Hits 9513 9539 +26
+ Misses 1056 1055 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
May 12, 2026
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
requested changes
May 22, 2026
efaulhaber
requested changes
May 26, 2026
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
approved these changes
May 26, 2026
Member
|
/run-gpu-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intervalbefore evaluating the steady-state kinetic-energy conditioninterval_sizevaluesRoot Cause
The discrete callback condition called
steady_state_condition!directly, sointervalwas never checked. The constructor also chose the previous kinetic-energy vector element type before converting tolerances to a floating type, which made integer tolerances try to storeInfas an integer.Validation
julia --project=. -e 'using Test, TrixiParticles; include("test/callbacks/steady_state_reached.jl")'