Skip to content

Add number of split integration time steps to summary#1194

Open
efaulhaber wants to merge 5 commits into
trixi-framework:mainfrom
efaulhaber:split-integration-summary
Open

Add number of split integration time steps to summary#1194
efaulhaber wants to merge 5 commits into
trixi-framework:mainfrom
efaulhaber:split-integration-summary

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

Before

#timesteps:    150 │ Δt: 5.5812e-03 │ sim. time: 6.1501e-01 (61.501%)  │ run time: 3.0417e+00 s
#timesteps:    200 │ Δt: 5.9424e-03 │ sim. time: 8.5756e-01 (85.756%)  │ run time: 3.1432e+00 s
────────────────────────────────────────────────────────────────────────────────────────────────────
Trixi simulation finished.  Final time: 1.0  Time steps: 231 (accepted), 231 (total)
────────────────────────────────────────────────────────────────────────────────────────────────────

──────────────────────────────────────────────────────────────────────────────────────────
           TrixiParticles.jl                     Time                    Allocations      
                                        ───────────────────────   ────────────────────────
           Tot / % measured:                 3.31s /  51.4%            736MiB /  59.9%    

With split integration:

────────────────────────────────────────────────────────────────────────────────────────────────────
Trixi simulation finished.  Final time: 0.01  Time steps: 60 (accepted), 60 (total)
────────────────────────────────────────────────────────────────────────────────────────────────────

Now

────────────────────────────────────────────────────────────────────────────────────────────────────
Trixi simulation finished.
  Final time:                            1.0
  Time steps:                            231 (accepted)        231 (total)
────────────────────────────────────────────────────────────────────────────────────────────────────

With split integration:

────────────────────────────────────────────────────────────────────────────────────────────────────
Trixi simulation finished.
  Final time:                           0.01
  Time steps:                             60 (accepted)         60 (total)
  Split integration time steps:         1960 (accepted)       1960 (total)
────────────────────────────────────────────────────────────────────────────────────────────────────

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

The PR improves the simulation finish summary printed by InfoCallback, switching to a vertically aligned multi-line format and adding a new line that reports accepted/total time steps from the inner split-integration integrator when present.

Changes:

  • Reformat the "simulation finished" summary using @printf with column alignment.
  • Add a new "Split integration time steps:" line when integrator.p.split_integration_data is not nothing.
  • Extend the info callback tests to cover both the standard and split-integration cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/callbacks/info.jl Rewrites print_summary with @printf formatting and conditionally prints split-integration step counts.
test/callbacks/info.jl Updates the existing finished-summary test for the new format and adds a new testset for the split-integration case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@efaulhaber efaulhaber requested a review from svchb May 15, 2026 15:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (5d46487) to head (d988b53).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/callbacks/info.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.02%     
==========================================
  Files         133      133              
  Lines       10452    10459       +7     
==========================================
+ Hits         9395     9400       +5     
- Misses       1057     1059       +2     
Flag Coverage Δ
total 89.87% <75.00%> (-0.02%) ⬇️
unit 70.49% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber efaulhaber added the enhancement New feature or request label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants