Fix Julia 1.10 CI fails due to hydrostatic tank validation#1205
Fix Julia 1.10 CI fails due to hydrostatic tank validation#1205efaulhaber wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
===========================================
- Coverage 89.88% 70.49% -19.40%
===========================================
Files 133 133
Lines 10452 10431 -21
===========================================
- Hits 9395 7353 -2042
- Misses 1057 3078 +2021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@svchb I don't understand why this is so inconsistent. macOS is passing because it's ARM, but why is Julia 1.11 Windows failing? |
|
I kept the tspan and resolution as small as possible to reduce the runtime. This variation should reduce with the longer sampling time. |
|
With the longer sampling time: Before: so the error reduced by 20-40%. |
|
My concern is the variation between CI runs, not the error itself. |
|
We kept the error bounds currently the same so the error is now well below the current bounds in the validation check. |
|
We still have a problem with inconsistent and especially non-deterministic differences. |
I could not figure out where the non-determinism comes from. This is the stupid fix now.