Fix deformation gradient performance in 3D#1220
Open
efaulhaber wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes the Total Lagrangian SPH (TLSPH) 3D deformation gradient accumulation by algebraically reordering the tensor-product/matrix multiplication to reduce computational cost while preserving the mathematical result.
Changes:
- Rewrites the deformation gradient neighbor contribution from
pos_diff * grad_kernel' * L_a'into an equivalent transposed form(L_a * grad_kernel * pos_diff')'. - Introduces a temporary
F_T(the transposed contribution) to make the faster evaluation order explicit and readable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.01%
==========================================
Files 136 136
Lines 10594 10596 +2
==========================================
+ Hits 9540 9541 +1
- Misses 1054 1055 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
requested changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@svchb and @copilot This should be mathematically identical, but please check carefully that this is indeed identical and I did not introduce an error here.
3D
2D