Fix long-running example tests in CI#1227
Open
efaulhaber wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces runtime for long-running example tests in CI by propagating shortened test parameters and selecting cheaper simulation settings where appropriate.
Changes:
- Overrides the density diffusion model for a fluid example test to use a faster formulation.
- Propagates
tspanthrough the nested FSI buoy example include. - Updates formatting and attempts to force serial execution for the falling rotating rigid squares example.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/examples/examples_fluid.jl |
Adds a faster density diffusion override for the periodic cylinder array test. |
examples/fsi/falling_rotating_rigid_squares_w_buoys_2d.jl |
Passes tspan into the nested base example include. |
examples/fsi/falling_rotating_rigid_squares_2d.jl |
Reformats several calls and adds a serial backend override to the semidiscretization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
- Coverage 90.05% 90.03% -0.02%
==========================================
Files 136 136
Lines 10594 10595 +1
==========================================
- Hits 9540 9539 -1
- Misses 1054 1056 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main:
This PR: