feat(configure): generate config/server.env with default and override env vars#45
Merged
Conversation
… env vars New 5.2 sub-step writes config/server.env: unconditional thread-limit defaults (OMP/OPENBLAS/NUMEXPR/MKL) enriched by the deploy.yml `env` dict (user values win). Written when missing; --recreate backs up and regenerates, mirroring odoo.conf. Forge-ID: 68041
Add the odoo.conf `config` overrides and the server.env `env` overrides to the schema example and options table. Forge-ID: 68041
| fg="yellow", | ||
| ) | ||
|
|
||
| # 5.2: config/server.env — default thread limits, enriched by deploy.yml `env`. |
Contributor
There was a problem hiding this comment.
can you please isolate it in its own step? env
Contributor
Author
There was a problem hiding this comment.
Thanks, @nilshamerlinck . The PR has been updated.
Move server.env out of the `config` step into a dedicated `env` step so it can be run or skipped independently. Forge-ID: 68041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Generate a
config/server.envfor odoo instances duringconfigure, so thesystemd unit's
EnvironmentFileis populated.Contents
envkey override those defaults.--recreate, keeping abackup of the previous one.
Forge-ID: 68041