func(vm): optimize selfdestruct restriction #6500
Closed
+90
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunny6889
reviewed
Dec 30, 2025
| byte[][] signatures = extractBytesArray( | ||
| words, words[3].intValueSafe() / WORD_SIZE, rawData); | ||
| if (VMConfig.allowTvmSelfdestructRestriction()) { | ||
| int sigArraySize = words[words[3].intValueSafe() / WORD_SIZE].intValueSafe(); |
There was a problem hiding this comment.
This should be a general improvement?
Contributor
Author
There was a problem hiding this comment.
Yep, we enhance processing efficiency by moving the judgment to the front end.
There was a problem hiding this comment.
Then the PR title and description better adjust accordingly.
Contributor
Author
There was a problem hiding this comment.
There is no difference; the goal is to optimize the proposal content.
Sunny6889
reviewed
Dec 30, 2025
| public void extendAndWrite(int address, int allocSize, byte[] data) { | ||
| extend(address, allocSize); | ||
| write(address, data, data.length, false); | ||
| write(address, data, allocSize, false); |
There was a problem hiding this comment.
Not sure whether below is better?
int writeSize = Math.min(allocSize, data.length);
write(address, data, writeSize, true);
Contributor
Author
There was a problem hiding this comment.
Your suggestion does not align with the original intent of this method's design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.