You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The version bump from 0.3.35 to 0.4.0 indicates a minor version change, but the appVersion changed from 1.17.35 to 1.18.0. Consider whether this should be a major version bump (1.0.0) if there are breaking changes in the application.
Why: The suggestion raises a valid point about semantic versioning alignment between the chart and the application, but the author's choice of a minor version bump is also a reasonable strategy.
The version bump from 0.3.35 to 0.4.0 indicates a minor version change, but the appVersion changed from 1.17.35 to 1.18.0. Consider whether this should be a major version bump (1.0.0) if there are breaking changes in the application.
Why: The suggestion raises a valid point about semantic versioning alignment between the chart and the application, but the author's choice of a minor version bump is also a reasonable strategy.
The chart version was bumped from 0.3.35 to 0.4.0 (major version bump) while appVersion changed from 1.17.35 to 1.18.0. Need to verify if this major version bump is intentional and follows the project's versioning strategy.
version: 0.4.0# This is the version number of the application being deployed. This version number should be# incremented each time you make changes to the application. Versions are not expected to# follow Semantic Versioning. They should reflect the version the application is using.# It is recommended to use it with quotes.appVersion: "1.18.0"
Docker image tags are using short commit hashes (63ee17, 56e5e8) instead of semantic versions. This makes it difficult to track what version is being deployed and may cause issues with rollbacks or version management.
The reason will be displayed to describe this comment to others. Learn more.
The versioning is likely wrong.
MAJOR.MINOR.PATCH
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes
The version bump from 0.3.35 to 0.4.0 indicates a minor version change, but the appVersion changed from 1.17.35 to 1.18.0. Consider whether this should be a major version bump (1.0.0) if there are breaking changes in the application.
Why: The suggestion raises a valid point about semantic versioning alignment between the chart and the application, but the author's choice of a minor version bump is also a reasonable strategy.
The version bump from 0.3.35 to 0.4.0 indicates a minor version change, but the appVersion changed from 1.17.35 to 1.18.0. Consider whether this should be a major version bump (1.0.0) if there are breaking changes in the application.
Why: The suggestion raises a valid point about semantic versioning alignment between the chart and the application, but the author's choice of a minor version bump is also a reasonable strategy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
What was the approach?
How can the changes made get tested?
Are there any concerns to addressed further before or after merging this PR?
Mentions?
Issue(s) affected?