You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please link to related issues when possible, and explain WHY you changed things, not WHAT you changed.
Other information:
eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
I checked that there were not similar issues or PRs already open for this.
This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.
PR Type
Enhancement
Description
Update Node.js version from 20.17.0 to 22.20.0
Upgrade pnpm version from 8 to 10.6.1
Improve Dockerfile ownership and directory structure
Why: This is a critical security improvement that ensures the container's runtime processes run as a non-root user, correctly extending the PR's security enhancements to the final application execution.
High
Possible issue
Run nginx in foreground
Modify the CMD instruction to run nginx in the foreground using the -g 'daemon off;' flag to prevent the container from exiting prematurely.
-CMD ["sh", "-c", "nginx && pnpm run pm2"]+CMD ["sh", "-c", "nginx -g 'daemon off;' && pnpm run pm2"]
Apply / Chat
Suggestion importance[1-10]: 8
__
Why: This suggestion correctly identifies that nginx will run as a daemon by default, which can cause the container to exit prematurely. Running it in the foreground is a critical fix for containerized applications.
Medium
Use frozen lockfile for reproducible installs
Add the --frozen-lockfile flag to the pnpm install command to ensure reproducible builds by using the exact dependency versions from the lockfile.
-RUN pnpm install+RUN pnpm install --frozen-lockfile
RUN NODE_OPTIONS="--max-old-space-size=4096" pnpm run build
Apply / Chat
Suggestion importance[1-10]: 7
__
Why: This is a valuable suggestion for ensuring reproducible builds in a Docker environment by locking dependency versions, which improves reliability and prevents unexpected issues in production.
Medium
More
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What kind of change does this PR introduce?
eg: Bug fix, feature, docs update, ...
Why was this change needed?
Please link to related issues when possible, and explain WHY you changed things, not WHAT you changed.
Other information:
eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
PR Type
Enhancement
Description
Update Node.js version from 20.17.0 to 22.20.0
Upgrade pnpm version from 8 to 10.6.1
Improve Dockerfile ownership and directory structure
Comment out schedule trigger in stale workflow
Diagram Walkthrough
File Walkthrough
build.yml
Update Node.js and pnpm versions.github/workflows/build.yml
stale.yml
Disable automatic schedule trigger.github/workflows/stale.yml
Dockerfile.dev
Improve Docker ownership and user managementDockerfile.dev