-
Notifications
You must be signed in to change notification settings - Fork 32
Refactor ecm_prep.main() #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aspeake
wants to merge
10
commits into
master
Choose a base branch
from
ecm_prep_main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86a110a to
9776c15
Compare
4b4900a to
5930567
Compare
d15f242 to
de7b05e
Compare
2df03c5 to
5f539ef
Compare
…p.main() into ECMPrepHelper.
5f539ef to
146f77c
Compare
fd76ca3 to
ed3658f
Compare
d3ffe6b to
daccf0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
main()function in ecm_prep.py. Summary of changes includes:ECMPrepHelperclass into new module to reduce ecm_prep.py file sizeECMPrepHelperwith new methods called frommain():get_measure_savings_shapes()import ecm prep shapes if applicableget_existing_measure_summary_data()import previously prepared measure attributesget_pkg_env_sep_info(): import envelope isolation measures, if applicableget_indiv_measures(): collect individual measures that require updatesget_measure_packages: collect measure packages that require updates