-
Notifications
You must be signed in to change notification settings - Fork 32
Comstock to Thermal Loads #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yingli-NREL
wants to merge
21
commits into
master
Choose a base branch
from
comstock_component_load
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jmythms
reviewed
Nov 21, 2025
scout/supporting_data/thermal_loads_data/comstock_to_thermalLoads.py
Outdated
Show resolved
Hide resolved
jmythms
reviewed
Jan 8, 2026
jmythms
reviewed
Jan 8, 2026
jmythms
reviewed
Jan 8, 2026
Collaborator
|
Apart from the comments above, things look good to me. The new plots also look great! Let's wait for @rHorsey's approval before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #535
This PR will update the current thermal load components data to the latest ComStock data.
There is a big difference between ComStock and Current Scout Data. The current Scout component load was based on very old DOE-2 models, with some inputs derived from the 1989 and 1992 CBECS. However, Comstock is pegged to 2018. Over the past ~30 years, commercial building efficiency has improved significantly. This likely explains much of the discrepancy we observe between the ComStock and Scout component load results. Back then, the solvers being used in the old DOE-2 models were of necessity quite a bit simpler.
In Scout,
EQUIP_ELECrepresents equipment gains, whileEQUIP_NELECrepresents other heat gain. The corresponding components in ComStock are equipment gains (equip_gain) and refrigeration gains (ref_equip_gain). Therefore, this PR change the Scout componnet load nameEQUIP_ELECtoEQUIPandEQUIP_NELECtoREFRIGKey notes:
Heating Window Conduction Load: High values in current Scout data (average absolute difference = 0.5). Some building types (e.g., large office) show component loads >1 in the current Scout data. Window insulation has improved significantly over the past ~30 years, greatly reducing heat loss through windows.Heating Light: Low values in current Scout data (average absolute difference = 0.59). some building types (e.g., food sales) show component loads <-1 in the current Scout data. Lighting efficiency has improved significantly over the past ~30 years, greatly reducing the amount of heat released by lighting.Floor component load: All values are zero in ComStock. Floor is floor with outdoor air exterior boundary condition. ComStock models don't have any outdoor air exterior boundary conditions for floors, so it's zero throughout.Heating Groundhas the large sign differences observed, only 98% samples have mismatched signs. High values in current Scout data (>0.5), while negative values in ComStock data. Because ComStock represents ground temperatures as constant monthly values with a three-month lag from average air temperatures, the ground may remain relatively warm during the heating season, reducing heating demand.Scatter plots:
More stats:
HEATING
COOLING
Calculation methods:
Mean diff = (ComStock-ScoutCurrentData).mean()
MAE = (|ComStock-ScoutCurrentData|).mean()
Sign Agree = (if sign_ComStock == sign_ScoutCurrentData).mean() to percentage
Correlation = ComStock.corr(ScoutCurrentData)
Stacked Bar Plots:
