feat: combine close same-net trace segments#391
Open
onchito-walks wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ion (tscircuit#378) - Add findCloseSameNetTraceGroups sub-solver that groups same-net traces by endpoint proximity (default threshold: 0.5mm) - Wire into TraceCleanupSolver init and output - Add focused test coverage for same-net grouping - All 62 tests pass, typecheck clean, build clean, format clean Addresses tscircuit#378
Adds a TraceCleanupSolver pipeline phase that merges close same-net trace segments after untangling and before turn minimization.\n\nIncludes unit coverage for same-net merging, reversed trace orientation, and keeping different nets separate.\n\nCo-authored-by: rdthree <rdthree@users.noreply.github.com>
onchito-walks
force-pushed
the
fix/combine-same-net-trace-segments
branch
from
43c6e00 to
7c64f0e
Compare
Author
|
Hey, just checking if you've had a chance to look at this. Happy to make any adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combineCloseSameNetTraceGroupshelper that merges close same-net trace segments while preserving original connection-pair ids and pin ids.combining_same_net_tracesphase intoTraceCleanupSolverafter untangling and before turn minimization.Verification
bun test tests/solvers/TraceCleanupSolver/findCloseSameNetTraceGroups.test.ts tests/solvers/TraceCleanupSolver/combineCloseSameNetTraceGroups.test.ts→ 4 passbunx tsc --noEmitbun run buildbun run format/claim #29