feat: add SameNetTraceCombiningSolver phase to merge close same-net t…#393
Open
voltrace-io wants to merge 2 commits into
Open
feat: add SameNetTraceCombiningSolver phase to merge close same-net t…#393voltrace-io wants to merge 2 commits into
voltrace-io wants to merge 2 commits into
Conversation
…race segments Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
SameNetTraceCombiningSolverpipeline phase that merges same-net trace segments running close together by snapping parallel segments onto a shared coordinate.How it works:
globalConnNetIdPipeline placement: After
TraceOverlapShiftSolver, beforeNetLabelPlacementSolver. Downstream solvers (TraceLabelOverlapAvoidanceSolver, etc.) now consume the combined output.Files changed:
lib/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.ts— new solver (207 lines)lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts— pipeline integrationtests/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.test.ts— 7 focused testsTests:
bun test— 69 pass, 4 skip, 0 fail (including example34)bunx tsc --noEmit— no type errorsbun run format:check— passes/claim #29
/claim #34
Also addresses #34 — the "merge same-net trace lines that are close together (make at the same Y or same X)" behavior. The snapping logic aligns nearby same-net horizontal segments to a shared Y coordinate and nearby vertical segments to a shared X coordinate, which is exactly the visual improvement described in #34. The existing
example34test passes with this solver in the pipeline (69 tests pass total).Review & Testing Checklist for Human
bun test— verify all tests passbunx tsc --noEmit— verify no type errorsNotes