Add same-net segment alignment cleanup#416
Open
haki203 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
haki203
force-pushed
the
fix-align-same-net-segments
branch
from
33bd16b to
b2d89cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add a final TraceCleanupSolver phase that aligns close overlapping internal horizontal/vertical segments on the same globalConnNetId\n- preserve endpoint anchors by only moving internal segments and simplifying the changed trace path\n- reject candidate moves that intersect chip obstacles or contact different-net traces, including endpoint contact\n- add focused regression coverage for same-net alignment, different-net no-op, and unsafe endpoint-contact no-op\n\n/claim #29\n\n## Verification\n- npx --yes biome check lib/solvers/TraceCleanupSolver/TraceCleanupSolver.ts lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts tests/solvers/TraceCleanupSolver/alignNearbySameNetSegments.test.ts\n- npx --yes bun test tests/solvers/TraceCleanupSolver/alignNearbySameNetSegments.test.ts tests/solvers/TraceCleanupSolver/TraceCleanupSolver.test.ts tests/examples/example29.test.ts tests/examples/example34.test.ts\n- npx --yes -p typescript tsc --noEmit\n- npx --yes bun run build\n- npx --yes bun test\n- git diff --check