Handle invalid route returns with ctx.json guidance#161
Open
Squirbie wants to merge 1 commit into
Open
Conversation
Author
|
Follow-up after checking the open PR queue: this overlaps materially with earlier clean invalid-route-return PRs, especially #156 and #157, and partially with narrower cases like #158/#152/#154. I missed those before opening this PR. Please treat this PR as an alternate/reference implementation rather than a first claim; I am happy to close it if maintainers prefer to keep the earlier candidates active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inoperator/claim #30
Validation
npx ava tests/errors/do-not-allow-raw-json.test.tsnpx prettier --check src/create-with-winter-spec.ts tests/errors/do-not-allow-raw-json.test.tsgit diff --checkNotes
npm ciis currently blocked because package-lock.json is not in sync with package.json for esbuild optional packages.npm test -- tests/errors/do-not-allow-raw-json.test.tsreaches the pretest build and is blocked by existing TypeScript errors insrc/cli/commands/codegen/openapi.tsandsrc/cli2/commands/codegen/openapi.tsaboutoperation.responsespossibly being undefined. The focused AVA regression test above passes.