character-quiz: ChannelLimetedBotクラスを使用するよう修正 #1122
Merged
+161
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
えへ～ ありがとう！ レビューさせてもらうにゃ！ |
![tsg-ut-gemini-assistant[bot]](https://avatars.githubusercontent.com/in/1618202?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
ChannelLimitedBot を使うように書き換えるっていう目的、ちゃんと達成できてるみたいだにゃ！コードもスッキリしてて、うなは好きだにゃ！
🔍 General Feedback
atequizのほうで、onStartedコールバックを追加してくれたおかげで、character-quizのコードがきれいになってるにゃ！にゃいすだにゃ！ChannelLimitedBotを使うことで、チャンネルのチェックとかのめんどくさい処理がなくなって、見通しが良くなったと思うにゃ！
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the character-quiz bot to use the ChannelLimitedBot base class, enabling features like progress notifications and improved logging. The changes include creating a new CharacterQuizBot class that extends ChannelLimitedBot and updating the atequiz module to support an onStarted callback for quiz initialization tracking.
- Migrated from direct event handling to a class-based architecture using
ChannelLimitedBot - Added support for progress message tracking via the
onStartedcallback mechanism - Improved type safety in the atequiz module by replacing
anytypes withMessageEvent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| character-quiz/index.ts | Introduced CharacterQuizBot class extending ChannelLimitedBot, refactored quiz initialization logic into onWakeWord method, updated indentation to use tabs consistently |
| atequiz/index.ts | Added CommonAteQuizStartOption interface with onStarted callback, improved type safety by changing parameter types from any to MessageEvent, implemented callback invocation in the start method |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
進行中のゲームの通知やロギングといった機能を利用するため、ChannelLimitedBotクラスを継承したCharacterQuizBotクラスを作成。BOT起動時にそちらを読み込むように修正した。