Fix wheels for macOS #3371
Merged
Fix wheels for macOS #3371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 29 29
Lines 31292 31292
Branches 5738 5738
=======================================
Hits 28089 28089
Misses 1794 1794
Partials 1409 1409
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Thanks @hugovk - can you review this please @benjeffery?
jeromekelleher
approved these changes
Jan 23, 2026
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
I'm going to go ahead and merge this as it all looks like it's working. Thanks again @hugovk!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Looks good - thanks @hugovk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The macos-14 wheel build has started failing:
https://github.com/tskit-dev/tskit/actions/runs/21176931185/job/60908346904
This is because
macos-14is now ARM-only.macos-15is still ARM-only, but there's a newmacos-15-intel:Also:
PR Checklist: