Open
Conversation
Sinon had a vulnerable sub-dependency, updated packages to resolve, but lots of changes to the dependencies meant having to change around tsconfig and package config to be able to build and test again
Author
|
Actually, don't merge this yet, have to pull out the npm publishing stuff I added so that I could use the fixes immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old Sinon packages had a downstream dependency on an old version of path-to-regexp, which is vulnerable: GHSA-9wv6-86v2-598j
Updating packages required adjustments to tsconfig and package config to be able to build and test again.