External Editor API crashes#9
Open
Plecra wants to merge 1 commit into
Open
Conversation
This adds a technical description of the problem to be used (and updated) by devtools developers.
Plecra
commented
Jan 29, 2021
| Things get weird when a connection | ||
| stays open for 3 seconds | ||
| without sending any packets. | ||
| In this case, |
Author
There was a problem hiding this comment.
Another way to crash the API:
let mut conn = net::TcpStream::connect("127.0.0.1:39999")?;
conn.write_all(br#"{ "messageID": 1, "scriptStates": [{ "guid": "-1", "script": "", "ui": "" }] }"#)?;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a technical description of the problem to be used (and updated) by devtools developers.
For most modders, the problem will be their editor misbehaving. I know the community has identified a few instances of this happening in atom (something about having multiple files open?). We should document these and how to fix them.