Adapt test_jittability to renamed ttsim target raw_results.columns_with_internal_p_ids#1196
Merged
Conversation
…th_internal_p_ids ttsim-dev/ttsim#131 splits raw_results.columns into columns_with_internal_p_ids / columns_with_original_p_ids. The former is computable from processed_data alone again, which is what this test relies on (see ttsim-dev/ttsim#130 for the breakage in 1.2.2.dev11). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
TODO: SWITCH TO TTSIM MAIN BEFORE MERGING (maybe capslock works 😄) |
Collaborator
I'll just wait with the approval 😜 |
MImmesberger
added a commit
to ttsim-dev/ttsim
that referenced
this pull request
Jun 7, 2026
…with_original_p_ids (#131) Closes #130. - Split `raw_results.columns` into `raw_results.columns_with_internal_p_ids` (computable from `processed_data` alone, endogenous `p_id_*` columns hold internal indices) and `raw_results.columns_with_original_p_ids` (the reverse-translation from #108, consumed by `results.tree`, so all `results.*` outputs keep returning user-space `p_id`s). - Both nodes are exposed via `MainTarget` and the `RawResults` main arg. - New `src_mettsim/tests_middle_earth/test_jittability.py` exercises the `processed_data`-only path over all mettsim column functions. - Breaking: the target `raw_results.columns` no longer exists; downstream switches to `columns_with_internal_p_ids` (ttsim-dev/gettsim#1196). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Hans-Martin von Gaudecker <hmgaudecker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ttsim-dev/ttsim#131