Merged
Conversation
…, STPH) with real-time GUI dashboard
…, STPH) with real-time GUI dashboard
A-Tarraf
requested changes
Jan 15, 2026
Member
There was a problem hiding this comment.
There are several points that need to be fixed before merging.
Several things mentioned under https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md are missing. This includes:
- Documentation and license for new files: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding test cases: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding a documentation: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
added 5 commits
January 21, 2026 01:25
Member
|
It looks much better! Thank you for your changes. Could you just maybe:
|
A-Tarraf
requested changes
Jan 27, 2026
A-Tarraf
requested changes
Feb 4, 2026
Member
A-Tarraf
left a comment
There was a problem hiding this comment.
only small function documentation are missing now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the three adaptive change point detection algorithms with a real-time visualization dashboard.
Algorithms: ADWIN, AV-CUSUM, STPH