Skip to content

fix: fromSeq stack-safe #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prikaz98 wants to merge 2 commits into
base: develop
Choose a base branch
from
+16 −2
Open

fix: fromSeq stack-safe #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e26135
fix: fromSeq stack-safe
Oct 30, 2024
9042fdc
fix: Simplify lambdas
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util-core/src/main/scala/com/twitter/concurrent/AsyncStream.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ object AsyncStream {
def fromSeq[A](seq: Seq[A]): AsyncStream[A] = seq match {
case Nil => empty
case _ if SeqUtil.hasKnownSize(seq) && seq.tail.isEmpty => of(seq.head)
case _ => seq.head +:: fromSeq(seq.tail)
case _ => of(seq.head).flatMap(_ +:: fromSeq(seq.tail))
}

/**
Expand Down
16 changes: 15 additions & 1 deletion util-core/src/test/scala/com/twitter/concurrent/AsyncStreamTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,20 @@ class AsyncStreamTest extends AnyFunSuite with ScalaCheckDrivenPropertyChecks {

assert(Await.result(stream.toSeq()) == Seq(n))
}

test(s"$impl: fromSeq is stack-safe") {
val n = 100000
val longSeq = (0 until n).toSeq
val stream = AsyncStream.fromSeq(longSeq)
.filter(_ > 10)
.filter(_ > 100)
.filter(_ > 1000)
.filter(_ > 10000)
.filter(_ > 100000)
.take(Int.MaxValue)

assert(Await.result(stream.toSeq.liftToTry).isReturn)
}
}

}
Expand Down Expand Up @@ -805,4 +819,4 @@ private object AsyncStreamTest {
}

def seqImpl: Seq[FromSeq] = Seq(Cons, EmbeddedCons, OfFuture, EmbeddedFuture)
}
}