Note in the README that iteration is impossible#21
Open
roryokane wants to merge 1 commit intotyler:masterfrom
Open
Note in the README that iteration is impossible#21roryokane wants to merge 1 commit intotyler:masterfrom
roryokane wants to merge 1 commit intotyler:masterfrom
Conversation
By the time I found out that this implementation does not provide `each`, I had already put this library in my `Gemfile` and started rewriting some methods to use this library. This disclaimer should prevent others from spending their time integrating with a trie implementation that does not fit their needs. This disclaimer is based on Tyler’s comment in issue tyler#19.
Owner
|
Holding off on this until I decide whether or not to implement libdatrie's iteration functionality. Leaning toward yes right now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time I found out that this implementation does not provide
each, I had already put this library in myGemfileand started rewriting some methods to use this library. This disclaimer should prevent others from spending their time integrating with a trie implementation that does not fit their needs.This disclaimer is based on Tyler’s comment in issue #19.