Fixed memory leaks in children, children_with_values, has_children?.#23
Open
henadzit wants to merge 2 commits intotyler:masterfrom
Open
Fixed memory leaks in children, children_with_values, has_children?.#23henadzit wants to merge 2 commits intotyler:masterfrom
henadzit wants to merge 2 commits intotyler:masterfrom
Conversation
…Removed redundant code from has_children?. Version bump to 0.5.2
Owner
|
Hi @henadzit! Thank you. This looks reasonable, but I'm trying to figure out why the 1.8.7 build is failing. Also, could you please rebase your branch and remove the updates to the trie.gemspec and VERSION.yml files? |
Contributor
Author
|
Actually, I updated VERSION.yml on purpose because, I think, we need to bump up patch version. I'm going to remove changes of gemspec. The build failed due to the known issue #14 |
Contributor
Author
|
Actually, I forgot to generate proper gemspec. I've updated it. |
Contributor
Author
|
Any update on this? |
Contributor
Author
|
Hey, any update on this? |
|
Would love to see this merged <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed redundant code from rb_trie_has_children (I realized that if the trie is traversed, there must be children below the search prefix).
Bumped version to 0.5.2.