[v0.x] Remove unbounded queue on server-side stream reception#545
Closed
timbertson wants to merge 2 commits intotypelevel:series/0.xfrom
Closed
[v0.x] Remove unbounded queue on server-side stream reception#545timbertson wants to merge 2 commits intotypelevel:series/0.xfrom
timbertson wants to merge 2 commits intotypelevel:series/0.xfrom
Conversation
For outgoing streams, this class delays outgoing messages until the underlying channel has capacity.
timbertson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disappointingly after testing #544, my simple test case of "client sends 2mb chunks as fast as it can, server takes 1s to process each chunk" still died a slightly slower death. Thankfully the fix is just to reuse the nice client-side stream reception code.
I haven't yet checked if this issue exists on
main, but I'm recording it as a necessary patch for v0.x to fully support backpressure.(note: this PR is only about the second commit, the first is already part of #544)