Upgrade ScalaPB to 1.0.0-alpha.3 to support protobuf 28#836
Open
jchyb wants to merge 1 commit intotypelevel:mainfrom
Open
Upgrade ScalaPB to 1.0.0-alpha.3 to support protobuf 28#836jchyb wants to merge 1 commit intotypelevel:mainfrom
jchyb wants to merge 1 commit intotypelevel:mainfrom
Conversation
In the new ScalaPB, symbols are returned with _root_ prefixes and (for scala 3) and `using` keywords are inserted. Because of that, related tests were adjusted and we filter out _root_ from packages (since it's an illegal name there).
Collaborator
|
prefixing generated with You could ask @thesamet what the plans are for releasing
Perhaps a more practical approach would be to maintain your own fork until 1.0.0 is released. I am happy to merge things that do not break existing code, but I am not going to maintain more than necessary, e.g. a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new ScalaPB, symbols are returned with root prefixes and (for scala 3) and
usingkeywords are inserted. Because of that, related tests were adjusted and we filter out_root_from packages (since it's an illegal name there).This is part PR, part question, since I realize there's an
alphain the version name - is it possible to merge this? Or merge into some branch and release via some separate/temporary version scheme?The reason for needing this is that there is some incompatibility when migrating a project to Bazel 8, caused by a necessary rules_java upgrade, which itself enforces a newer protobuf version. Regardless of the reason, I think it would be helpful to get this in.