Wrote test and fixed the bug for conflate chunk#3699
Open
ankitkumarrain wants to merge 1 commit intotypelevel:mainfrom
Open
Wrote test and fixed the bug for conflate chunk#3699ankitkumarrain wants to merge 1 commit intotypelevel:mainfrom
ankitkumarrain wants to merge 1 commit intotypelevel:mainfrom
Conversation
ankitkumarrain
changed the title
Contributor
Author
|
Hey Maintainers , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Number - 3661
The main cause of the bug was Channel.bounded when pulled, emits buffered values (additional value) that appends values from blocked producers. So, Channel.bounded(3) can emit (n+1), 4 elements for higher iterations.
Proposed fix : I made a fix Channel.bounded (chunklimit -1) ensures the emitted chunk never exceeds chunklimit.
Stream.eval(Channel.bounded[F2, Chunk[O]](chunkLimit- 1)).flatMap { chan =>
I wrote a test Conflate chunk respect chunklimit , for 1000 iterations which passed the test with the above fix.