Centralized file for messages

[NimperX]

Centralized file for messages #90

[jellz]

You don't need to include : string in every declaration, it is inferred

Also, instead of

const message = 'text';
export { message };

you can just do

export const message = 'text';

[ckiee]

We need a way to store messages with templates too, not sure how yet but this can be discussed.

[jellz]

We need a way to store messages with templates too, not sure how yet but this can be discussed.

We can just export functions instead of strings from the file

// template
export const templateMessage = (a: string) => `${a} is used here`;

// static
export const staticMessage = () => 'static message';

[ckiee]

We need a way to store messages with templates too, not sure how yet but this can be discussed.

We can just export functions instead of strings from the file

// template
export const templateMessage = (a: string) => `${a} is used here`;

// static
export const staticMessage = () => 'static message';

This won't allow us to use the Discord.js toString() overrides as TypeScript will be mad.
Additionally, it will be quite big as we have to have that whole thing for each message.

p.s. haven't slept for a while, gonna write in more detail tomorrow.

[NimperX]

We need a way to store messages with templates too, not sure how yet but this can be discussed.

In that case I think using a message class would be a perfect solution.

export class Message {
	functionWithStaticMessage(): string { return 'some text'; }

	functionWithParameter(a: string): string { return 'value of a is' + a; }
}

[ckiee]

@robertt Thoughts?

Personally I don't really like this since you have to make an instance of the class and the static keyword on every method would probably just make this even longer.
I'd like some Rust/Python-ey solution that lets us just have a object of strings and a function to call to populate stuff like %s but that seems quite far fetched for TS.

[jellz]

Consider:

export const messages = {
    staticMessage: () => 'static message here',
    templateMessage: (a: string) => `this is a template, ${a}`
}

Short lines and simplicity.

[robertt]

@jellz 👍, would probably be worth putting it in an object, so for example:

const messages = {
    commands: {
      rep: {
           toSelf: () => ':x: you cannot send rep to yourself',
           success: (member: string) => `:ok_hand: successfully sent rep to ${member}`
      }  
    },
};

[ckiee]

LGTM other then the previous unresolved comment but we still need to figure out how to organize the actual messages nicely.

p.s. we should probably consider future i18n too

[cspotcode]

Anything blocking this from being merged?

[ckiee]

In addition to the review comments I'd also like to mention you should try to make the constant's names a bit more detached from the sentence.

E.g. beAskerToCloseChannel -> noChannelClosePerms / cannotSendRepToYou -> noSelfRep. (or something like that)

[ckiee]

Good enough.