Refactor path resolution#82
Open
saecki wants to merge 1 commit into
Open
Conversation
Member
Author
|
(The test script currently doesn't seem to work on macos :/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
The refactor happened somewhat incidentally during my investigation of what was actually happening.
I figured out that the
expect_parentscode path was essentially dead, because the templates root dir was passed in instead of the packages root dir. So theprepare_packagewas always hit as a fallback.I took the liberty of renaming that function to better reflect what they are actually doing, since we don't download any packages.