zarzadzanie-pwr:1.0.0#5112
Conversation
|
Checks do not pass because bot does not have typst 0.15.0 which is required by package |
saecki
left a comment
There was a problem hiding this comment.
Thanks for this package!
Checks do not pass because bot does not have typst 0.15.0 which is required by package
That was an oversight on our side. We released version 0.6.0 of the package check which supports Typst 0.15.0, but the github action still pulled in the 0.5.0 version of the package check image. This should now be fixed and if you rebase onto main the new version should be run in the CI.
I've run the package check locally and the package builds as expected. But there are still a few warnings regarding the use of snake_case instead of kebab-case.
| autor: "Imię i Nazwisko", | ||
| kierunek: [], | ||
| specjalnosc: [], | ||
| rodzaj_pracy: [], |
There was a problem hiding this comment.
These parameters seem to be using snake_case instead of kebab-case. This is a bit inconsistent with the other ones below. Could you change them?
|
Hello. Can you please update your package submission to take into account the comments above? In case you don't have time to do so for now, I will close this PR to keep our review backlog organized. You can of course open a new PR once you have fixed the mentioned issues. |
I am submitting
Description: "Master's thesis template for management faculty of Wrocław University of Science and Technology based on official faculty guidelines"
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE