ricopallazzo-uni-theme:0.1.0#5175
Conversation
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for submitting this template! I have left a few comments that would need to be addressed before it can be published.
There was a problem hiding this comment.
From a quick look, this file doesn't seem to be used anywhere. Can you remove it please?
| #let ricopallazzo-uni-theme = ricopallazzo-uni-theme | ||
| #let alert-box = alert_box | ||
| #let title-slide = title-slide |
There was a problem hiding this comment.
The first and last let don't change anything, and the second one could also be avoided by naming the function correctly in the first place. I would suggest replacing all of this file with
#import "src/theme.typ": ricopallazzo-uni-theme, alert-box, title-slide| @@ -0,0 +1,196 @@ | |||
| # Ricopallazzo UNI Theme | |||
|
|
|||
| A modern, customizable presentation theme for **Typst** built on top of **Touying**. It provides a polished academic presentation layout with automatic section slides, progress indicators, branded headers and footers, and configurable color themes. | |||
There was a problem hiding this comment.
Since you seem ship assets for the Milan University by default, I think it would be worth mentioning here.
By the way, does the template conform to the University guidelines, or is it just re-using the logos?
|
|
||
| ## Installation | ||
|
|
||
| Once published on Typst Universe: |
There was a problem hiding this comment.
You can assume that the package is already published, otherwise people wouldn't be able to read this version of the README.
| author: "Alberto Bertoncini", | ||
| institute: "University of Milan", | ||
| theme: "blue", | ||
| logo: "../assets/logo_RGB_negative_circle.png", |
There was a problem hiding this comment.
Passing a string literal won't work in most cases. You should use path or take a piece of content directly.
There was a problem hiding this comment.
Regarding the assets:
- Do you have the right to distribute them?
- If so, can you specify under which license/terms they are placed (in the "License" section of your README for example)?
- If not, can you please remove them or replace them with placeholder images?
There was a problem hiding this comment.
Once you will have fixed the str versus path issue, you will be able to delete this copy of the assets.
| @@ -0,0 +1,30 @@ | |||
| #import "@preview/touying:0.7.4": * | |||
| #import "../src/theme.typ": * | |||
There was a problem hiding this comment.
It is generally appreciated to use @preview/… imports in example files, so that they can be copy/pasted as is by users.
There was a problem hiding this comment.
Same for these assets as the ones in examples/.
There was a problem hiding this comment.
This file is not linked to from your README: it will be quite hard to discover for people browsing Typst Universe. Can you either remove it (along with the rest of the examples directory) or link to it in your README?
I am submitting
Description: This PR adds the
ricopallazzo-uni-themepackage (v0.1.0).The package provides a modern presentation theme built on top of Touying,
featuring:
typst initThe package has been tested locally both as a package (
@local) and as a template.I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE