Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the enum parsing so that enum variants are correctly included as fields in the parsed structure.
- Updated the attribute extraction logic to skip comment nodes when searching for attributes.
- Added a new code block to extract enum variants from an enum's body and populate them as fields.
- Introduced tests in the fixtures to verify public and private enum parsing.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/parser/lang/rust.rs | Updated enum parsing by extracting variants and reusing extracted attributes and documentation. |
| fixtures/sample_enum.rs | Added sample enums and test cases to validate the new enum variant parsing behavior. |
Files not reviewed (1)
- .cursor/rules/rust.mdc: Language not supported
Comments suppressed due to low confidence (1)
src/parser/lang/rust.rs:310
- [nitpick] Consider renaming 'fields' to 'variants' for clarity, as this variable stores enum variant information rather than struct fields.
let mut fields = Vec::new();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.