Skip to content

Conversation

@neilflood
Copy link
Member

This addresses the discussion in #10 around VRT support

In the end, the solution was even simpler than the one discussed.

  • It is an exception to give parents when adding history to a VRT file
  • Only currentfile metadata is saved in the VRT. No lineage information is stored at all, deferred or otherwise.
  • When reading history out of a VRT, all component files must be present (or the VRT would not work). So, the read function recursively reads the history from component files and adds it as though they were parents of the VRT. This creates the lineage on-the-fly.
  • The code for merging in parent history has moved to be a method in the class, so it can be shared between normal creation of a history object and on-the-fly creation for a VRT.

Note that this solution still does nothing to address the metadata size overflow problem mentioned. This mainly relates to GTiff format, but still needs care. It is possible we should do some separate fix for this, but that can come later.

@neilflood neilflood requested a review from gillins August 23, 2025 03:52
Copy link
Member

@gillins gillins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good and very neat!

@neilflood neilflood merged commit 7f7e355 into ubarsc:main Aug 24, 2025
2 checks passed
@neilflood neilflood deleted the vrt-support branch August 24, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants