Update escape function for convertSvg#2190
Open
ryanrath wants to merge 4 commits into
Open
Conversation
ryanrath
added
maintenance / code quality
aaronweeden
requested changes
Apr 14, 2026
This commit just updates the function used to escape the data that will ultimately passed to exif for exporting SVG versions of XDMoD charts. Tests were added for Usage and Metric Explorer tabs.
jpwhite4
reviewed
Apr 14, 2026
| 'font_size' => '3', | ||
| 'featured' => 'false', | ||
| 'trendLineEnabled' => 'undefined', | ||
| 'x_axis' => urldecode('%257B%257D'), |
Member
There was a problem hiding this comment.
why hardcode a urlencoded string in order to urldecode it?
Contributor
Author
There was a problem hiding this comment.
This has been updated in the latest commit.
jpwhite4
requested changes
Apr 14, 2026
Contributor
Author
|
Ok, the PR has all the actual changes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit just updates the function used to escape the data that will ultimately passed to exif for exporting SVG versions of XDMoD charts.
Motivation and Context
Using the right escape functions is a plus.
Tests performed
All automated tests run / passed.
Integration tests were added for chart export from both Usage and Metric Explorer.
Checklist: