Add composite index on aggregate table#2199
Open
eiffel777 wants to merge 10 commits into
Open
Conversation
eiffel777
requested review from
aaronweeden,
aestoltm,
connersaeli,
jpwhite4,
rvtovar and
ryanrath
eiffel777
added
enhancement
jpwhite4
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the indexes for dimension values to be composite indexes with the aggregation unit id as the first column. The improves performance and let's the query be run without using
STRAIGHT_JOINto get optimal performance.Because of the new indexes, some statistics have slightly different values. I have updated the affected integration and regression tests. I also added a sql file to the upgrade section in
bootstrap.shto drop and re-create the indexes onmodw_aggregates.jobfact_by_dayas this was the only way I could get a consistent result between the fresh install and upgrade tests.Tests performed
Tested in docker and on xdmod-dev
Checklist: