Fix PyPI trusted publishing: add id-token: write to upload_all#928
Merged
Conversation
The v0.17.0 publish workflow failed with "OpenID Connect token retrieval failed: missing or insufficient OIDC token permissions" because the upload_all job lacked `id-token: write`, which PyPI trusted publishing (OIDC) requires. #871 switched to trusted publishing but never added the permission, and v0.17.0 was the first release to exercise it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jeongyoonlee
requested review from
alexander-pv,
huigangchen,
paullo0106,
ppstacy,
ras44,
t-tte,
vincewu51 and
zhenyuz0500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PyPI trusted publishing (
id-token: write)The v0.17.0 publish workflow failed at the
upload_allstep:The
upload_alljob was missingid-token: write, which PyPI trusted publishing (OIDC) requires. #871 switched from an API token to trusted publishing but never added the permission, and v0.17.0 was the first release to actually exercise it — so all wheels built successfully but the PyPI upload failed (nothing was published).This adds the job-level permission. After merge, the v0.17.0 release will be re-cut to re-trigger the publish.