Modularize orchestrator wiring: extract queue profiles, topic registry builder, and controller registration#290
Draft
JamyDev wants to merge 1 commit into
Draft
Modularize orchestrator wiring: extract queue profiles, topic registry builder, and controller registration#290JamyDev wants to merge 1 commit into
JamyDev wants to merge 1 commit into
Conversation
Propose extracting per-queue extension profiles, topic-registry builder, and controller registration from the orchestrator example main.go into reusable domain packages, plus data-driven profile hints in QueueConfig. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JamyDev
changed the title
JamyDev
commented
Jun 30, 2026
|
|
||
| This keeps the controller list in the domain layer (testable, importable) and reduces the wiring main.go to: build dependencies → call `wire.RegisterPrimary` → call `wire.RegisterDLQ`. Adding a new pipeline stage becomes a single-file edit in this package. | ||
|
|
||
| ### 4. Extend `QueueConfig` with optional profile hints |
Contributor
Author
There was a problem hiding this comment.
This may be a bit controversial @behinddwalls :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an RFC at doc/rfc/submitqueue/modular-queue-wiring.md proposing 5 extractions to make the orchestrator's queue setup more modular:
Also adds the RFC to doc/rfc/index.md. Doc-only change, no code modifications.
Test Plan
CI/Build validation
Revert Plan
git revert
Jira Issues
API Changes
No API changes
Monitoring and Alerts
Standard monitoring via existing dashboards
🤖 Generated by minion
Co-Authored-By: minion-bot noreply@minion.uber.com
Co-Authored-By: jamy@uber.com
Agent: claude-code | Task: b069bea1-12a5-478a-b517-61ce0abd6749
View your task: https://minion.uberinternal.com/task/b069bea1-12a5-478a-b517-61ce0abd6749