Fx module wiring and lifecycle cleanup#129
Closed
yushan8 wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract comparison logic into controller/comparer.go
Graph comparison logic moved out of getchangedtargets.go into a
targetGraphComparertype. The controller calls newTargetGraphComparer(...).Compare(...) directly — no wrapper method.Move per-request init to construction time in nativeOrchestrator
Remove dead appCtx from orchestrator and repomanager
Both stored an application-lifetime context but never read it. Removed. Only the controller retains appCtx — it's actually used for linkRequestCtx and fire-and-forget cache writes.
Make all Params structs Fx-injectable
Add module/module.go
fx.Module("tango") wires repomanager → orchestrator → controller. Documents what callers must supply.
Convert example/main.go to Fx
Uses fx.New(...).Run() with fx.Lifecycle hooks for dispatcher start/stop, temp directory cleanup, and signal-based shutdown.