Extract targetGraphComparer into separate module#131
Closed
yushan8 wants to merge 1 commit into
Closed
Conversation
yushan8
commented
Jun 30, 2026
Contributor
- Extract targetGraphComparer into controller/comparer.go — moves the graph comparison logic (target diffing, BFS distance computation, ID remapping, seed classification, metadata chunking) out of getchangedtargets.go into a focused, self-contained type
- GetChangedTargets calls newTargetGraphComparer(...).Compare(...) directly instead of going through a compareTargetGraphs wrapper method on the controller
- Helper functions that only serve the comparison algorithm (transposeOptimizedTarget, computeDistances, changedDepStatus, hasChangedSourceFileDep, attributesChanged, getTargetsAndMetadata, buildNameIndex, detectSourceFileID, canonicalTargetName, validateTargetNames) move to comparer.go
- Tests that exercised compareTargetGraphs now use newTestComparer().Compare(...) directly, removing the need for newTestController in those tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.