Skip to content

Clean up logging in controller and wrap errors#132

Open
yushan8 wants to merge 6 commits into
mainfrom
update-logging
Open

Clean up logging in controller and wrap errors#132
yushan8 wants to merge 6 commits into
mainfrom
update-logging

Conversation

@yushan8

@yushan8 yushan8 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
  • Removed redundant logger.Error calls where the error was already being returned
  • Replaced common.WithReason with fmt.Errorf wrapping in getchangedtargets.go.
  • Promoted cache read failures and corrupt blob warnings from logger.Warn + silent fallthrough to hard errors in getchangedtargets.go.
  • Propagated cachedReader.Close() errors instead of ignoring them.
  • Made ws.Release() errors in native_orchestrator.go surface via multierr.Append instead of being swallowed.
  • Fixed tests to match the new error wrapping.

@yushan8 yushan8 requested review from a team as code owners June 30, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant