Closed
Conversation
+ Ensure test run by invoking them using node (as opposed to directly invoking the file path); + Allow the comparisons to be tolerant of different EOLs
temp listens to the exit event to run cleanupSync(). tape puts in a event listener on exit event before it that terminates the program preventing temp from cleaning up. To circumvent this we clean up all temp directories manually. process.chdir() locks the directory on Windows preventing rimraf (invoked by temp.cleanupSync()) from deleting the directory. Thus, we no longer change the working directory, instead calculating the file path of temp files using path.join() and invoking the binary with the `cwd` option.
uber-licence can be invoked through a Javascript API that is equivalent to the CLI. Documentation has been updated to reflect these changes. Improved Documentation - added a table explaining all options.
|
|
Author
|
Sorry about that, See #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created an explicit API version and a separated the CLI code from it. This I intend as a step towards making uber-licence a more general purpose tool.
I have also fixed some bugs in the tests on Windows and improved upon the documentation.