Added proxy link in react's package.json and added login api code in …#2
Open
prasadpise wants to merge 1 commit intomasterfrom
Open
Added proxy link in react's package.json and added login api code in …#2prasadpise wants to merge 1 commit intomasterfrom
prasadpise wants to merge 1 commit intomasterfrom
Conversation
…index.js of node server. Also added api calling code from react for login api in App.js
yashkarle
reviewed
Mar 5, 2019
| "not op_mini all" | ||
| ] | ||
| ], | ||
| "proxy": "http://193.1.131.26:8888/" |
There was a problem hiding this comment.
this is fine for now, we should look for generalisation and not hard code any values for that matter
yashkarle
reviewed
Mar 5, 2019
|
|
||
| // use the access token to access the Spotify Web API | ||
| request.get(options, function(error, response, body) { | ||
| console.log(body); |
There was a problem hiding this comment.
not sure if we just want to print the body and its internals on the console, probable TODO
yashkarle
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…index.js of node server. Also added api calling code from react for login api in App.js