Skip to content

🐛 Fix stacked plots functionality by ensuring multiple output var… #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-ashe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Fix stacked plots functionality by ensuring multiple output var… #4068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions process/io/plot_scans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,18 +591,7 @@ def main(args=None):
# -----------
for index, output_name in enumerate(output_names):
if stack_plots:
# check stack plots will work
if len(output_names) <= 1:
raise ValueError(
"For stack plots to be used need more than 1 output variable"
)
fig, axs = plt.subplots(
len(output_names),
1,
figsize=(8.0, (3.5 + (1 * len(output_names)))),
sharex=True,
)
fig.subplots_adjust(hspace=0.0)
pass
Copy link
Collaborator

@timothy-nunn timothy-nunn Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite this if statement to avoid just having a pass

else:
fig, ax = plt.subplots()
if output_names2 != []:
Expand Down Expand Up @@ -684,11 +673,25 @@ def main(args=None):
plt.tight_layout()
else:
if stack_plots:
axs[output_names.index(output_name)].plot(
# check stack plots will work
if len(output_names) <= 1:
raise ValueError(
"For stack plots need more than 1 output variable"
)
# Create subplots only once for the first output
if index == 0:
fig, axs = plt.subplots(
len(output_names),
1,
figsize=(8.0, (3.5 + (1 * len(output_names)))),
sharex=True,
)
fig.subplots_adjust(hspace=0.0)

axs[index].plot(
scan_var_array[input_file],
output_arrays[input_file][output_name],
"--o",
color="blue" if output_names2 != [] else None,
label=labl,
)
if y_axis_range != []:
Expand Down