Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #713 +/- ##
===========================================
- Coverage 98.87% 96.33% -2.54%
===========================================
Files 68 69 +1
Lines 4337 4451 +114
===========================================
Hits 4288 4288
- Misses 49 163 +114
Continue to review full report at Codecov.
|
RemDelaporteMathurin
approved these changes
Feb 9, 2021
Collaborator
Author
|
I'm half tempted to hold of on this till we get Cubit in the CI and testing becomes easier. I've still not got around to locally testing this as I've been having VPN / license server issues |
I would recommend holding off on this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating the Cubit / Trelis script that makes the DAGMC geometry thanks to suggestions from @GregVernon made over on this issue #711
Thanks very much for helping out Greg
Also noticed a few missing indents for the reflecting surfaces which I'm sure I've fixed before
We can test this locally and get it merged in to develop soon
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist